add a route of element screenshot for converted request as MJSONWP #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -224,6 +224,9 @@ | |||
| routeMap.addRoute(new RouteDefinition(Method.POST, "/session/:sessionId/appium/execute_mobile/backdoor", new MobileBackdoor(), MobileBackdoorParams.class)); | |||
| routeMap.addRoute(new RouteDefinition(Method.POST, "/session/:sessionId/appium/execute_mobile/:elementId/flash", new MobileViewFlash(), ViewFlashParams.class)); | |||
|
|
|||
| // Compatibility for https://github.com/appium/appium-base-driver/blob/master/lib/jsonwp-proxy/protocol-converter.js | |||
There was a problem hiding this comment.
actually, this route is the correct one for the JSONWP protocol. Having a comment the W3C one is an alias to this one would be enough: https://github.com/appium/appium-uiautomator2-server/blob/20de6220d4d9b888892b8e148a1e16b6aa8b874d/app/src/main/java/io/appium/uiautomator2/server/AppiumServlet.java#L157
mykola-mokhnach
approved these changes
Jan 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appium/appium#11988
A converted in base driver converts getting element screenshot from W3C to MJSONWP. The converted request sends to Espresso server.
The converted checked if it converts a request with response status. I think adding this URL is reasonable to change the converter's logic for v1.11.0 release.
cc @dpgraham
Can you take a look and include this into 1.11.0 if this way is approval?
This will fix failing taking element screenshot in Appium 1.9.?, 1.10.0 and comming 1.11.0