Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tiemzone and locale in deviceinfo #465

Merged
merged 3 commits into from
Jul 6, 2019
Merged

Add tiemzone and locale in deviceinfo #465

merged 3 commits into from
Jul 6, 2019

Conversation

KazuCocoa
Copy link
Member

Added timezone and locale as same as appium/appium-xcuitest-driver#1003

@driver.execute_script 'mobile: deviceInfo', {}
=> {"realDisplaySize"=>"1080x1920",
 "apiVersion"=>"28",
 "carrierName"=>"Android",
 "platformVersion"=>"9",
 "timeZone"=>"Asia/Tokyo",
 "model"=>"Android SDK built for x86_64",
 "locale"=>"ja_JP",
 "brand"=>"google",
 "androidId"=>"918a8c16d0e7c7ec",
 "manufacturer"=>"Google",
 "displayDensity"=>420}

This was referenced Jul 6, 2019
Merged
Merged
mykola-mokhnach
mykola-mokhnach reviewed Jul 6, 2019
View reviewed changes
...sso-server/app/src/androidTest/java/io/appium/espressoserver/lib/helpers/DeviceInfoHelper.kt Outdated
@@ -24,6 +24,7 @@ import android.telephony.TelephonyManager
import android.util.DisplayMetrics
import android.view.Display
import android.view.WindowManager
import java.util.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually try to avoid star imports and use specific ones

@mykola-mokhnach mykola-mokhnach merged commit 8280b13 into appium:master Jul 6, 2019
@KazuCocoa KazuCocoa deleted the add-tiemzone-and-locale branch July 6, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KazuCocoa @mykola-mokhnach