-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set do not suppress accessibility services for uiautomation #468
Conversation
// The flag is necessary not to stop running accessibility service | ||
// https://github.com/appium/appium/issues/4910 | ||
// https://developer.android.com/reference/android/app/UiAutomation.html#FLAG_DONT_SUPPRESS_ACCESSIBILITY_SERVICES | ||
Configurator.getInstance().uiAutomationFlags = UiAutomation.FLAG_DONT_SUPPRESS_ACCESSIBILITY_SERVICES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we probably should do
Configurator.getInstance().uiAutomationFlags = Configurator.getInstance().uiAutomationFlags | UiAutomation.FLAG_DONT_SUPPRESS_ACCESSIBILITY_SERVICES;
In order to not corrupt the current flags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also prefer to have this option configurable via capabilities to make sure it does not affect current tests
41e66d3
to
b5e94be
Compare
Roughly tried to define a custom runner to handle
|
@KazuCocoa It this PR still relevant? |
Espresso driver has a couple of methods which call
UiDevice.getInstance
, appium/appium#4910 may happen.This affects below methods.
GetAlertText
/DismissAlert
/AcceptAlert
Uiautomator
by mobile command