fix set value immediately, replace value #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espresso-server/app/src/androidTest/java/io/appium/espressoserver/lib/handlers/ElementValue.kt
Outdated
Show resolved
Hide resolved
| @@ -1,5 +1,5 @@ | |||
| package io.appium.espressoserver.lib.model | |||
|
|
|||
| data class ElementValueParams( | |||
There was a problem hiding this comment.
w3c also requires text parameter to be set, which contains a string rather than array
There was a problem hiding this comment.
Okay. Will add text and update routes, too
https://github.com/appium/appium-base-driver/blob/master/lib/protocol/routes.js
| } | ||
|
|
||
| val viewInteraction = Element.getViewInteractionById(elementId) | ||
| if (isReplacing) { | ||
| viewInteraction.perform(replaceText(value)) | ||
| } else { | ||
| viewInteraction.perform(typeText(value)) | ||
| try { |
There was a problem hiding this comment.
is this block of code duplicated?
There was a problem hiding this comment.
A part of.
Will refactor as another PR (SendKeys.kt)
| Pair(first=true, second=false) -> params.text!! | ||
| else -> params.value!!.joinToString() // for backward-compatibility | ||
| Pair(first=false, second=true) -> params.value!!.joinToString(separator="") // for MJSONWP | ||
| else -> params.text!! // Prior W3C |
There was a problem hiding this comment.
actually, text was added in W3C
mykola-mokhnach
approved these changes
Aug 15, 2019
KazuCocoa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below error happens for set immediate value and replace value.
Tested in Ruby to make the behaviour the same as UIA2
https://dev.azure.com/kazucocoa/ruby_lib_core/_build/results?buildId=1265