fix: Exclude transitive dependencies of espresso-contrib #596
Conversation
| androidTestImplementation "androidx.test.espresso:espresso-contrib:$espresso_version" | ||
| androidTestImplementation "androidx.test.espresso:espresso-core:$espresso_version" | ||
| androidTestImplementation("androidx.test.espresso:espresso-contrib:$espresso_version") { | ||
| transitive = false |
There was a problem hiding this comment.
I would say it makes sense to add a comment here or a link the actual PR with a short explanation about why transitive deps are disabled
There was a problem hiding this comment.
Added in f9b1622.
|
Somehow, I knew it won't be that easy. Okay, back to the drawing board |
What exactly is complicated? The PR itself is ok |
|
Indeed, PR looks simple, but tests are failing for SDK_30 (when I run tests locally they work) and SDK_23 (haven't looked at that one yet) |
|
they were failing even before. It looks like it's partially an azure issue (the emulator is just too slow and times out unexpectedly) |
|
simply add the comment and I would be happy to merge the PR |
|
I've added a comment with short description. This may not finish all the "Drawable and Lifecycle" issues as there is other PR (#506 ) that took this work further. In one case I had to use I guess I'm trying to say that there is a room for improvements. |
There always is. Lets do it in small steps. |
grzegorz-jarosz
deleted the
fix/exclude_transitive_dependencies_of_espresso-contrib
branch
This PR takes forward work started by @tinder-ktarasov in his PR #497, hoping that this will fix issues in #449.
Initial submission had some failing tests (but logs are no longer accessible).
In a short setting "transitive = false" stops gradle from loading espresso-contrib's dependendencies. However, adding it fails one of the tests with some "Navigation" class missing. After adding "com.google.android.material:material:1.2.0" this test no longer failed.
Note that android.material package is in espresson-contrib dependencies, so in fact we're removing all but one of dependent packages from build.
I'm not sure if that's the right "gradle" solution. I'm open for a discussion.