Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Allow target SDK 29 #604

Merged

Conversation

rasim-sitmanbetov
Copy link
Contributor

In order to test our application, we need to build the espresso test app with Target SDK version 29.

To do so, I've addressed several minor changes.

@jsf-clabot
Copy link

jsf-clabot commented Sep 21, 2020

CLA assistant check
All committers have signed the CLA.

@rasim-sitmanbetov rasim-sitmanbetov changed the title Allow target SDK 29 refactor: Allow target SDK 29 Sep 21, 2020
Copy link
Contributor

@dpgraham dpgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rasim-sitmanbetov
Copy link
Contributor Author

@dpgraham may I ask you for assist?

I've changed the title according to the rules in Semantic Pull Request. How could I retry the check?
I could make a dummy commit with a valid message, but I don't want to avoid triggering the rest of the check again.

Thank you!

@mykola-mokhnach mykola-mokhnach merged commit 1fc1db2 into appium:master Sep 21, 2020
@rasim-sitmanbetov rasim-sitmanbetov deleted the target-sdk-29-support branch September 25, 2020 11:17
rasim-sitmanbetov added a commit to rasim-sitmanbetov/appium-espresso-driver that referenced this pull request Sep 25, 2020
refactor: Allow target SDK 29 (appium#604)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants