feat: Speed up xpath lookup by only including the requested attributes #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
approved these changes
Dec 9, 2020
| import kotlin.test.assertEquals | ||
| import kotlin.test.assertNull | ||
|
|
||
| class `Xpath Query Parser Tests` { |
There was a problem hiding this comment.
ah, I thought we had Truth in androidx, but it seems this did not as an assertion library.
| viewText?.let { | ||
| setAttribute(ViewAttributesEnum.TEXT, it.rawText) | ||
| setAttribute(ViewAttributesEnum.HINT, it.isHint) | ||
| if (null == includedAttributes || includedAttributes.contains(ViewAttributesEnum.INDEX)) { |
There was a problem hiding this comment.
How about define a variable for null == includedAttributes?
val shouldSetAllAttributes = null == includedAttributes
if (shouldSetAllAttributes || includedAttributes.contains(ViewAttributesEnum.INDEX)) {
// ...
}There was a problem hiding this comment.
I've refactored it in more functional style
KazuCocoa
approved these changes
Dec 9, 2020
| recordAdapterViewInfo(view) | ||
| var isTextOrHintRecorded = false | ||
| var isAdapterInfoRecorded = false | ||
| linkedMapOf( |
KazuCocoa
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Querying view attributes is expensive and takes time. Although xpath lookup only requires some attributes to be there and does not need them all