chore: Gradle Kotlin DSL #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
reviewed
Mar 20, 2021
|
|
||
| dependencies { | ||
| implementation(fileTree(mapOf("dir" to "libs", "include" to listOf("*.jar")))) | ||
| // additionalAppDependencies placeholder (don't change or delete this line) |
There was a problem hiding this comment.
Espresso driver dynamically modifies some placeholders like here by https://github.com/appium/appium-espresso-driver#espresso-build-config , so they also should be updated to this syntax. (Probably add ()?)
There was a problem hiding this comment.
I fixed the additional dependencies and also I updated the documentation links.
|
@tinder-ktarasov could you please review this PR and confirm it works for you? |
mykola-mokhnach
approved these changes
Mar 29, 2021
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle build scripts in Kotlin DSL
build.gradle.ktsscripts with identical functionality as the originalbuild.gradlescripts.Improvements
Gradle Kotlin DSL documentation
Note