Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add disableAnalytics true #666

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

KazuCocoa
Copy link
Member

@@ -231,6 +231,7 @@ class EspressoRunner {
'am', 'instrument',
'-w',
'-e', 'debug', process.env.ESPRESSO_JAVA_DEBUG === 'true',
'-e', 'disableAnalytics', true, // To avoid unexpected error by google analytics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume true should be a string rather than a boolean

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine with the current way.
When I ran with this line (both true and 'true'), logcat got UsageTrackerFacilitator: Usage tracking disabled. But without this line, nothing appeared.

@KazuCocoa KazuCocoa merged commit 9aaa13a into appium:master Apr 16, 2021
@KazuCocoa KazuCocoa deleted the disable-analytics branch April 16, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants