Make sure keys gets arguments right #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| keys = keys.join(''); | ||
| } | ||
| if (!_.isString(keys)) { | ||
| keys = `${keys}`; |
There was a problem hiding this comment.
is this the same as keys = keys.toString()?
There was a problem hiding this comment.
It is, as long as keys is an array with a string inside. I think the spec says it ought to take an array of characters, in which case ['a', 'b', 'c'].toString() == 'a,b,c'
There was a problem hiding this comment.
Hmm, I was more commenting on what we would prefer to standardize on if
`${keys}`
and
keys.toString()
are equivalent.
There was a problem hiding this comment.
Ah! I see. Yes, toString is better. And not sure why I went with the other, to be perfectly honest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get an array sometimes. Make sure we send a string along.
See appium/appium#6441