Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update simulator preferences handling #298

Merged
merged 8 commits into from
Dec 10, 2020

Conversation

mykola-mokhnach
Copy link
Contributor

Plist preference files on macOS are managed by cfprefsd. Changing the file itself without letting the daemon know about it has no effect. Read https://eclecticlight.co/2017/07/06/sticky-preferences-why-trashing-or-editing-them-may-not-change-anything/ and https://shadowfile.inode.link/blog/2018/06/advanced-defaults1-usage/ for more details

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

am reading the attached articles, too.
just a moment to finish this review

@@ -0,0 +1,69 @@
import { toXmlArg, generateUpdateCommandArgs } from '../../lib/defaults-utils';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mykola-mokhnach mykola-mokhnach merged commit 7f6b71d into appium:master Dec 10, 2020
@mykola-mokhnach mykola-mokhnach deleted the defaults branch December 10, 2020 06:43
@KazuCocoa
Copy link
Member

Read https://eclecticlight.co/2017/07/06/sticky-preferences-why-trashing-or-editing-them-may-not-change-anything/
I usually used defaults to modify plist, but did not know the background... interesting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants