feat: add webDriverAgentMacUrl #41

KazuCocoa · 2021-01-02T21:38:01Z

webDriverAgentMacUrl works as same as iOS/webDriverAgentUrl.

This allows us to launch an appium server on a machine and handle mac2 driver on another macOS machine.
(Mainly I want this capability to develop mac2 driver on my environment so far)

README.md

lib/wda-mac.js

mykola-mokhnach · 2021-01-05T11:29:26Z

lib/wda-mac.js

+    }
+    return {
+      scheme,
+      server: hostname ?? DEFAULT_SYSTEM_HOST,


I would say we should throw an exception if hostname cannot be parsed

same about protocol

Will do this later

I did this raising an exception in https://github.com/appium/appium-mac2-driver/pull/41/files#diff-cb3604d19b5cec159d0260eb8b8739d21bf074cf54584fd2b555e9969caaa92fR335-R341 (url.URL)

lib/wda-mac.js

KazuCocoa · 2021-01-06T08:52:16Z

lib/wda-mac.js

+    let wasProcessInitNecessary;
+    if (this.isProxyingToRemoteServer) {
+      if (this.process) {
+        await this.process.stop();


Like below error happened only await cleanupObsoleteProcesses(); case.

[debug] [HTTP] Request idempotency key: 20ac39e4-5f3c-47ae-904a-cc197b645fed [HTTP] --> POST /wd/hub/session [HTTP] {"desiredCapabilities":{"platformName":"mac","automationName":"mac2","webDriverAgentMacUrl":"http://localhost:10100"},"capabilities":{"firstMatch":[{"platformName":"mac","appium:automationName":"mac2","appium:webDriverAgentMacUrl":"http://localhost:10100"}]}} [debug] [W3C] Calling AppiumDriver.createSession() with args: [{"platformName":"mac","automationName":"mac2","webDriverAgentMacUrl":"http://localhost:10100"},null,{"firstMatch":[{"platformName":"mac","appium:automationName":"mac2","appium:webDriverAgentMacUrl":"http://localhost:10100"}]}] [debug] [BaseDriver] Event 'newSessionRequested' logged at 1609921937694 (00:32:17 GMT-0800 (Pacific Standard Time)) [Appium] Appium v1.20.0-rc.1 creating new Mac2Driver (v0.8.1) session [debug] [BaseDriver] W3C capabilities and MJSONWP desired capabilities were provided [debug] [BaseDriver] Creating session with W3C capabilities: { [debug] [BaseDriver] "alwaysMatch": { [debug] [BaseDriver] "platformName": "mac", [debug] [BaseDriver] "appium:automationName": "mac2", [debug] [BaseDriver] "appium:webDriverAgentMacUrl": "http://localhost:10100" [debug] [BaseDriver] }, [debug] [BaseDriver] "firstMatch": [ [debug] [BaseDriver] {} [debug] [BaseDriver] ] [debug] [BaseDriver] } [BaseDriver] Session created with session id: 7f3ec82f-86fe-47f6-8710-43746bd24077 [debug] [WebDriverAgentMac] Cleaning up 4 obsolete processes [debug] [WD Proxy] Matched '/status' to command name 'getStatus' [debug] [WD Proxy] Proxying [GET /status] to [GET http://localhost:10100/status] with no body [WebDriverAgentMac] Mac2Driver host process has exited with code null, signal SIGKILL [WD Proxy] connect ECONNREFUSED 127.0.0.1:10100 [debug] [BaseDriver] Event 'newSessionStarted' logged at 1609921937749 (00:32:17 GMT-0800 (Pacific Standard Time)) [debug] [W3C] Encountered internal error running command: Error: An unknown server-side error occurred while processing the command. Original error: Could not proxy command to the remote server. Original error: connect ECONNREFUSED 127.0.0.1:10100 [debug] [W3C] at WDAMacServer.isProxyReady (/Users/kazuaki/GitHub/appium-mac2-driver/lib/wda-mac.js:301:15) [debug] [W3C] at processTicksAndRejections (internal/process/task_queues.js:97:5) [debug] [W3C] at waitMs (/Users/kazuaki/GitHub/appium-mac2-driver/lib/wda-mac.js:395:44) [debug] [W3C] at spin (/Users/kazuaki/GitHub/appium-mac2-driver/node_modules/asyncbox/lib/asyncbox.js:113:20) [debug] [W3C] at waitForCondition (/Users/kazuaki/GitHub/appium-mac2-driver/node_modules/asyncbox/lib/asyncbox.js:129:10) [debug] [W3C] at WDAMacServer.startSession (/Users/kazuaki/GitHub/appium-mac2-driver/lib/wda-mac.js:395:9) [debug] [W3C] at Mac2Driver.createSession (/Users/kazuaki/GitHub/appium-mac2-driver/lib/driver.js:84:7) [debug] [W3C] at AppiumDriver.createSession (/Users/kazuaki/.nodebrew/node/v14.3.0/lib/node_modules/appium/lib/appium.js:371:35) [HTTP] <-- POST /wd/hub/session 500 171 ms - 915 [HTTP]

But kills/stops processes by await this.process.stop(); like current implementation could wait like below log. So, for now, cleanupObsoleteProcesses is to cleanup RUNNING_PROCESS_IDS.. (.stop worked, then this method only clean RUNNING_PROCESS_IDS)

[debug] [HTTP] Request idempotency key: 07159145-27ac-4d3f-9724-a3ab455e0ca7 [HTTP] --> POST /wd/hub/session [HTTP] {"desiredCapabilities":{"platformName":"mac","automationName":"mac2","webDriverAgentMacUrl":"http://localhost:10100"},"capabilities":{"firstMatch":[{"platformName":"mac","appium:automationName":"mac2","appium:webDriverAgentMacUrl":"http://localhost:10100"}]}} [debug] [W3C] Calling AppiumDriver.createSession() with args: [{"platformName":"mac","automationName":"mac2","webDriverAgentMacUrl":"http://localhost:10100"},null,{"firstMatch":[{"platformName":"mac","appium:automationName":"mac2","appium:webDriverAgentMacUrl":"http://localhost:10100"}]}] [debug] [BaseDriver] Event 'newSessionRequested' logged at 1609922453348 (00:40:53 GMT-0800 (Pacific Standard Time)) [Appium] Appium v1.20.0-rc.1 creating new Mac2Driver (v0.8.1) session [debug] [BaseDriver] W3C capabilities and MJSONWP desired capabilities were provided [debug] [BaseDriver] Creating session with W3C capabilities: { [debug] [BaseDriver] "alwaysMatch": { [debug] [BaseDriver] "platformName": "mac", [debug] [BaseDriver] "appium:automationName": "mac2", [debug] [BaseDriver] "appium:webDriverAgentMacUrl": "http://localhost:10100" [debug] [BaseDriver] }, [debug] [BaseDriver] "firstMatch": [ [debug] [BaseDriver] {} [debug] [BaseDriver] ] [debug] [BaseDriver] } [BaseDriver] Session created with session id: 5103782c-9eb7-49b7-b5d7-9d24cac34ed1 [WebDriverAgentMac] Mac2Driver host process has exited with code null, signal SIGTERM [debug] [WebDriverAgentMac] Cleaning up 3 obsolete processes [debug] [WD Proxy] Matched '/status' to command name 'getStatus' [debug] [WD Proxy] Proxying [GET /status] to [GET http://localhost:10100/status] with no body [WD Proxy] connect ECONNREFUSED 127.0.0.1:10100 [debug] [WD Proxy] Matched '/status' to command name 'getStatus' [debug] [WD Proxy] Proxying [GET /status] to [GET http://localhost:10100/status] with no body [WD Proxy] connect ECONNREFUSED 127.0.0.1:10100 [debug] [WD Proxy] Matched '/status' to command name 'getStatus' [debug] [WD Proxy] Proxying [GET /status] to [GET http://localhost:10100/status] with no body [WD Proxy] connect ECONNREFUSED 127.0.0.1:10100 [debug] [WD Proxy] Matched '/status' to command name 'getStatus' [debug] [WD Proxy] Proxying [GET /status] to [GET http://localhost:10100/status] with no body [WD Proxy] connect ECONNREFUSED 127.0.0.1:10100 [debug] [WD Proxy] Matched '/status' to command name 'getStatus' [debug] [WD Proxy] Proxying [GET /status] to [GET

hm..
(I tweaked the order of killing process etc in cleanupObsoleteProcesses, but no luck. So something other things affected?)

I think I know what the issue might be. Please call this.process.kill() first and then cleanupObsoleteProcesses. The issue there is that the process gets killed from the outside (by the kill -9 command line utility), so the original process object does not get notified about it is killed, which is ok when we close the server, but not ok when we about to start a new session

mykola-mokhnach

LGTM. Only #41 (comment) is left

mykola-mokhnach · 2021-01-06T20:27:26Z

lib/wda-mac.js

+      };
+    }
+
+    let parsed_url;


KazuCocoa added 5 commits January 2, 2021 01:23

feat: add webDriverAgentUrl

73e5b0d

add tests

d6c524a

fix

f4b06ec

add docstring

4b2f2d8

tweak

d979188

KazuCocoa requested a review from mykola-mokhnach January 2, 2021 21:38

mykola-mokhnach reviewed Jan 2, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Jan 2, 2021

View reviewed changes

lib/wda-mac.js Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Jan 2, 2021

View reviewed changes

lib/wda-mac.js Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Jan 2, 2021

View reviewed changes

lib/wda-mac.js Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Jan 2, 2021

View reviewed changes

lib/wda-mac.js Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Jan 2, 2021

View reviewed changes

lib/wda-mac.js Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Jan 2, 2021

View reviewed changes

lib/wda-mac.js Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Jan 2, 2021

View reviewed changes

lib/wda-mac.js Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Jan 2, 2021

View reviewed changes

lib/wda-mac.js Show resolved Hide resolved

KazuCocoa changed the title ~~feat: add webDriverAgentMacUrl~~ [wip] feat: add webDriverAgentMacUrl Jan 3, 2021

KazuCocoa added 6 commits January 2, 2021 19:04

add e.g. in readme

799ac19

simplify opts.webDriverAgentMacUrl check

85919ab

return early

b188c8d

Merge branch 'master' into add-usewdaurl

5712287

update test

07276ce

simplify condition

38a2925

KazuCocoa marked this pull request as draft January 3, 2021 09:14

mykola-mokhnach reviewed Jan 3, 2021

View reviewed changes

lib/wda-mac.js Outdated Show resolved Hide resolved

KazuCocoa added 4 commits January 3, 2021 02:39

tmp

dd66d78

add isProxying

083f45f

tweak

d5516a0

tweak

5c3cd14

KazuCocoa changed the title ~~[wip] feat: add webDriverAgentMacUrl~~ feat: add webDriverAgentMacUrl Jan 4, 2021

KazuCocoa marked this pull request as ready for review January 4, 2021 03:12

replace isRunning

9640b44

KazuCocoa force-pushed the add-usewdaurl branch from 1758dac to 9640b44 Compare January 5, 2021 07:31

mykola-mokhnach reviewed Jan 5, 2021

View reviewed changes

lib/wda-mac.js Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Jan 5, 2021

View reviewed changes

lib/wda-mac.js Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Jan 5, 2021

View reviewed changes

lib/wda-mac.js Show resolved Hide resolved

mykola-mokhnach reviewed Jan 5, 2021

View reviewed changes

lib/wda-mac.js Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Jan 5, 2021

View reviewed changes

lib/wda-mac.js Show resolved Hide resolved

KazuCocoa added 3 commits January 5, 2021 09:31

remove redundant shouldPrepareProxy

2130a05

test more

a846d80

exist previous process

548eb51

KazuCocoa changed the title ~~feat: add webDriverAgentMacUrl~~ [wip] feat: add webDriverAgentMacUrl Jan 5, 2021

mykola-mokhnach reviewed Jan 5, 2021

View reviewed changes

lib/wda-mac.js Show resolved Hide resolved

mykola-mokhnach reviewed Jan 5, 2021

View reviewed changes

lib/wda-mac.js Outdated Show resolved Hide resolved

add todo

49c4f95

KazuCocoa marked this pull request as draft January 5, 2021 20:00

KazuCocoa added 2 commits January 5, 2021 22:40

use URL()

4c7573d

fix to kill

ca9dda0

KazuCocoa changed the title ~~[wip] feat: add webDriverAgentMacUrl~~ feat: add webDriverAgentMacUrl Jan 6, 2021

KazuCocoa marked this pull request as ready for review January 6, 2021 07:13

KazuCocoa requested a review from mykola-mokhnach January 6, 2021 07:14

Merge branch 'master' into add-usewdaurl

ab16e4b

KazuCocoa marked this pull request as draft January 6, 2021 08:24

KazuCocoa commented Jan 6, 2021

View reviewed changes

KazuCocoa marked this pull request as ready for review January 6, 2021 08:54

replace stop to kill

7b6c390

mykola-mokhnach approved these changes Jan 6, 2021

View reviewed changes

KazuCocoa merged commit 9e4add0 into appium:master Jan 6, 2021

KazuCocoa deleted the add-usewdaurl branch January 6, 2021 17:52

mykola-mokhnach reviewed Jan 6, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add webDriverAgentMacUrl #41

feat: add webDriverAgentMacUrl #41

KazuCocoa commented Jan 2, 2021

mykola-mokhnach Jan 5, 2021

mykola-mokhnach Jan 5, 2021

KazuCocoa Jan 5, 2021

KazuCocoa Jan 6, 2021

KazuCocoa Jan 6, 2021 •

edited

Loading

mykola-mokhnach Jan 6, 2021

mykola-mokhnach left a comment

mykola-mokhnach Jan 6, 2021

KazuCocoa Jan 6, 2021

feat: add webDriverAgentMacUrl #41

feat: add webDriverAgentMacUrl #41

Conversation

KazuCocoa commented Jan 2, 2021

mykola-mokhnach Jan 5, 2021

Choose a reason for hiding this comment

mykola-mokhnach Jan 5, 2021

Choose a reason for hiding this comment

KazuCocoa Jan 5, 2021

Choose a reason for hiding this comment

KazuCocoa Jan 6, 2021

Choose a reason for hiding this comment

KazuCocoa Jan 6, 2021 • edited Loading

Choose a reason for hiding this comment

mykola-mokhnach Jan 6, 2021

Choose a reason for hiding this comment

mykola-mokhnach left a comment

Choose a reason for hiding this comment

mykola-mokhnach Jan 6, 2021

Choose a reason for hiding this comment

KazuCocoa Jan 6, 2021

Choose a reason for hiding this comment

KazuCocoa Jan 6, 2021 •

edited

Loading