fix: handle async execute on iOS without awaitPromise #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/remote-debugger.js
Outdated
| `window.${promiseName}.resolve = res;` + | ||
| `window.${promiseName}.reject = rej;` + | ||
| `window.${promiseName};`; | ||
| const script = `var res, rej;` + |
There was a problem hiding this comment.
I would say quotes also support multiline strings, so pluses are redendant
mykola-mokhnach
approved these changes
Feb 5, 2020
jlipps
approved these changes
Feb 5, 2020
| @@ -419,41 +419,44 @@ class RemoteDebugger extends events.EventEmitter { | |||
| } | |||
|
|
|||
| async executeAtomAsync (atom, args, frames) { | |||
| // helper to send directly to the web inspector | |||
| const evaluate = async (method, opts) => { | |||
| return await this.rpcClient.send(method, { | |||
There was a problem hiding this comment.
return is not needed
mykola-mokhnach
approved these changes
Feb 5, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS 12.1 MobileSafari within a frame the
windowobject gets reset (or we have a different window object?) when going through the atom. But since the code injected is known and stable, and also just retrieving values with no side effects, we can just run it directly.