Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure react components work #202

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Conversation

imurchie
Copy link
Contributor

Update the atoms to handle React inputs. I've run this against the entire appium-xcuitest-driver suite, as well as against a couple of React web apps (simple test apps and a production site).

See appium/appium#9002

@mykola-mokhnach
Copy link
Contributor

No way to merge the PR to original Selenium atoms without waiting eternity until it gets reviewed and merged?

Copy link
Contributor

@mykola-mokhnach mykola-mokhnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@imurchie imurchie merged commit 8e4cd52 into appium:master Feb 18, 2020
@imurchie imurchie deleted the isaac-react branch February 18, 2020 21:52
@KazuCocoa
Copy link
Member

Brilliant 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants