This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
build: fix node caching in travis #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
approved these changes
Dec 11, 2019
| if [[ $(npm ls --depth 1 -g opencv4nodejs) =~ "── opencv4nodejs@" ]]; then | ||
| echo 'Already installed opencv4nodejs'; | ||
| else | ||
| npm install -g opencv4nodejs; |
There was a problem hiding this comment.
travis was killing the job previously because the build command was printing too much of data into the log and/or was printing no data at all within 30 min making Travis think it's frozen. That is why the trick with ping.sh was needed
There was a problem hiding this comment.
It seems fine now. I've run it a number of times without running over the log limit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable global
node_modulescaching in Travis. Also remove the masking of the install process foropencv4nodejsas, in the event of an error in install/build, it makes the problem unclear.