Skip to content
This repository has been archived by the owner on Oct 25, 2023. It is now read-only.

feat: Add file name sanitizer to the fs module #168

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Conversation

mykola-mokhnach
Copy link
Contributor

No description provided.

Copy link
Contributor

@imurchie imurchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will Appium usage always include a replacement option? If so, perhaps it could be made the default here?

@mykola-mokhnach
Copy link
Contributor Author

Will Appium usage always include a replacement option?

I wanted to make it configurable. By default this is just an empty string (means invalid chars are just cut off: https://github.com/parshap/node-sanitize-filename#readme)

@imurchie
Copy link
Contributor

Yeah, saw that in the docs. But if, say, Appium generally uses - as the replacement, it could be defaulted here while still maintaining the configurability.

@mykola-mokhnach mykola-mokhnach merged commit d237ce4 into master Mar 18, 2020
@mykola-mokhnach mykola-mokhnach deleted the sanitizer branch March 18, 2020 16:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants