This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
feat: add getLockFileGuard method to util #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlipps
changed the title
|
I would rather use some ready solution like https://www.npmjs.com/package/lockfile and create a wrapper over it inside appium-support |
jlipps
force-pushed
the
jlipps/file-lock
branch
from
6dfdb05
to
37197e9
Compare
|
@mykola-mokhnach updated. I did actually look for something like this ahead of time but somehow didn't come across this implementation! |
jlipps
force-pushed
the
jlipps/file-lock
branch
from
37197e9
to
af889b1
Compare
|
comments addressed! |
jlipps
force-pushed
the
jlipps/file-lock
branch
from
af889b1
to
912f051
Compare
jlipps
force-pushed
the
jlipps/file-lock
branch
from
912f051
to
4d0c059
Compare
mykola-mokhnach
approved these changes
Apr 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the idea is to support guarding behaviors across multiple processes: appium/appium#13463 (review)