add mjpeg stream helper class #75
Conversation
lib/mjpeg.js
Outdated
|
|
||
| // use the deferred pattern so we can wait for the start of the stream | ||
| // based on what comes in from an external pipe | ||
| let startPromise = new B((res, rej) => { |
lib/mjpeg.js
Outdated
| * Start reading the MJpeg stream and storing the last image | ||
| */ | ||
| async start (serverTimeout = MJPEG_SERVER_TIMEOUT_MS) { | ||
| this.consumer = new MJpegConsumer(); |
There was a problem hiding this comment.
should we call stop here first ?
| * it closes the connection | ||
| * @returns {http.Server} | ||
| */ | ||
| function initMJpegServer (port, intMs = 300, times = 20) { |
There was a problem hiding this comment.
I'd rather put this helper method into tests
There was a problem hiding this comment.
it will be used by the drivers though, so it needs to be exported from appium-support
test/mjpeg-specs.js
Outdated
| it('should error out if the server does not send any images before a timeout', async function () { | ||
| let stream = new MJpegStream(MJPEG_SERVER_URL, _.noop); | ||
| await stream.start(0).should.eventually.be.rejectedWith(/never sent/); | ||
| stream.stop(); |
There was a problem hiding this comment.
stop might not always be called if a test fails.
|
@mykola-mokhnach added png translation support |
lib/mjpeg.js
Outdated
| null; | ||
| } | ||
|
|
||
| async lastChunkPNG () { |
There was a problem hiding this comment.
a docstring might be useful
|
@imurchie any thoughts or comments on this before i merge? |
lib/mjpeg.js
Outdated
| import { Writable } from 'stream'; | ||
| import { fs } from 'appium-support'; | ||
|
|
||
| const IMAGE_PATH = path.resolve(__dirname, '..', '..', 'test', 'images', |
There was a problem hiding this comment.
test/ is currently not included in the npm release, so this won't exist (fine for declaration, since path.resolve doesn't do anything to the contents, but not for the usage later).
There was a problem hiding this comment.
ah yes, good point. i'll find somewhere else for it to go.
There was a problem hiding this comment.
you could encode the simplest one-pixel-like image into base64-string and put it directly there
|
ok @mykola-mokhnach @imurchie changes made, what do you think now? |
|
published as 2.18.0 |
the new version of appium/appium-base-driver#230