This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
add some jimp helper functionality #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * convenient for our async/await model. | ||
| * | ||
| * @param {Buffer|string} data - binary image buffer or base64-encoded image | ||
| * string |
There was a problem hiding this comment.
missing return description
lib/image-util.js
Outdated
| * @param {Buffer|string} data - binary image buffer or base64-encoded image | ||
| * string | ||
| */ | ||
| async function getJimpImage (data) { |
There was a problem hiding this comment.
Perhaps toJimpImage ?
There was a problem hiding this comment.
hmm, if this were a method on an object i would like that, but since it's just a bare function that feels confusing to me. open to other ideas though.
mykola-mokhnach
approved these changes
Jul 19, 2018
imurchie
reviewed
Jul 19, 2018
lib/image-util.js
Outdated
| async function getJimpImage (data) { | ||
| return await new B((resolve, reject) => { | ||
| if (!_.isString(data) && !_.isBuffer(data)) { | ||
| throw new Error("Must initialize jimp object with string or buffer"); |
There was a problem hiding this comment.
Probably better to reject rather than throw in here, so as not to mix metaphors.
|
published in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was finding that i was having to do lots of bluebird messiness just to use jimp in a few different places. this PR puts all that messiness in one place.