-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make tap by coordinates working #163
Conversation
Addresses appium/appium#10581 |
Is there any chance to merge this PR? |
This seems to have been forgotten about. @mykola-mokhnach is it still okay to merge this as-is? |
@dpgraham I believe appium/appium-android-driver#355 should be merged and published first. As far as I remember @imurchie was concerned about the current implementation, but he unfortunately had no time to provide a better one. |
Mykola Mokhnach seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
It turns out that
parseTouch
helper inside android driver module always calculates absolute element coordinates instead of relative. Although these coordinates when being passed toclick
method of uia2 server are ignored and the tap action is simply translated toelement.click
. This change assumes that if coordinates are defined for thetap
call then these coordinates are always absolute.