Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make tap by coordinates working #163

Merged
merged 5 commits into from
Apr 20, 2020

Conversation

mykola-mokhnach
Copy link
Contributor

It turns out that parseTouch helper inside android driver module always calculates absolute element coordinates instead of relative. Although these coordinates when being passed to click method of uia2 server are ignored and the tap action is simply translated to element.click. This change assumes that if coordinates are defined for the tap call then these coordinates are always absolute.

@mykola-mokhnach
Copy link
Contributor Author

Addresses appium/appium#10581

lib/commands/element.js Outdated Show resolved Hide resolved
@valfirst
Copy link

valfirst commented Aug 9, 2018

Is there any chance to merge this PR?

@dpgraham
Copy link
Contributor

This seems to have been forgotten about. @mykola-mokhnach is it still okay to merge this as-is?

@mykola-mokhnach
Copy link
Contributor Author

@dpgraham I believe appium/appium-android-driver#355 should be merged and published first. As far as I remember @imurchie was concerned about the current implementation, but he unfortunately had no time to provide a better one.

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mykola-mokhnach
❌ Mykola Mokhnach


Mykola Mokhnach seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@mykola-mokhnach mykola-mokhnach changed the title Fix tap by coordinates fix: Make tap by coordinates working Apr 19, 2020
@mykola-mokhnach mykola-mokhnach merged commit ebc44e4 into appium:master Apr 20, 2020
@mykola-mokhnach mykola-mokhnach deleted the fix_tap_coord branch April 20, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants