Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permissions handling mobile endpoints #305

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Add permissions handling mobile endpoints #305

merged 1 commit into from
Mar 15, 2019

Conversation

mykola-mokhnach
Copy link
Contributor

@dpgraham
Copy link
Contributor

Is there a way to test this using the ApiDemos app?

@dpgraham
Copy link
Contributor

A simple E2E test of just:

  • check getPermission
  • call changePermission with whatever
  • check getPermission again to see that the change is reflected

@mykola-mokhnach
Copy link
Contributor Author

@dpgraham The permission must be a "real" one, otherwise it won't work. API target for Appium demos must be 23+ to support that

@mykola-mokhnach mykola-mokhnach merged commit 9be69ae into appium:master Mar 15, 2019
@mykola-mokhnach mykola-mokhnach deleted the perms branch March 17, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgraham dpgraham dpgraham approved these changes

@KazuCocoa KazuCocoa KazuCocoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mykola-mokhnach @dpgraham @KazuCocoa