Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions handling mobile endpoints #305

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
3 participants

@mykola-mokhnach mykola-mokhnach requested review from dpgraham and KazuCocoa Mar 14, 2019

@dpgraham

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

Is there a way to test this using the ApiDemos app?

@dpgraham

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

A simple E2E test of just:

  • check getPermission
  • call changePermission with whatever
  • check getPermission again to see that the change is reflected
@mykola-mokhnach

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

@dpgraham The permission must be a "real" one, otherwise it won't work. API target for Appium demos must be 23+ to support that

@mykola-mokhnach mykola-mokhnach merged commit 9be69ae into appium:master Mar 15, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@mykola-mokhnach mykola-mokhnach deleted the mykola-mokhnach:perms branch Mar 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.