Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a capability of waitForLaunch #327

Merged
merged 2 commits into from Jul 29, 2019

Conversation

@KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented Jul 28, 2019

Closes appium/appium#12962

appium-adb already has an option, waitForLaunch, to remove -W for instrument command.
waitForLaunch is true by default.

This PR add the ability for UIA2.

  • With appWaitForLaunch
[debug] [ADB] Running '/Users/kazu/Library/Android/sdk/platform-tools/adb -P 5037 -s emulator-5554 shell am start -n io.appium.android.apis/io.appium.android.apis.ApiDemos -S -a android.intent.action.MAIN -c android.intent.category.LAUNCHER -f 0x10200000'
  • Without appWaitForLaunch (or true)
[debug] [ADB] Running '/Users/kazu/Library/Android/sdk/platform-tools/adb -P 5037 -s emulator-5554 shell am start -W -n io.appium.android.apis/io.appium.android.apis.ApiDemos -S -a android.intent.action.MAIN -c android.intent.category.LAUNCHER -f 0x10200000'

Espresso driver does not call startApp, so this change is needed for this repo.

@KazuCocoa
Copy link
Member Author

@KazuCocoa KazuCocoa commented Jul 28, 2019

Will add this cap in caps for in Appium repo after merging this change.

@KazuCocoa KazuCocoa merged commit 4d394ce into appium:master Jul 29, 2019
5 of 7 checks passed
@KazuCocoa KazuCocoa deleted the km/add-wait-for-launch-capability branch Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants