-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add settings related to UIAutomator2 mjpeg [screen] streaming feature + cleanup #386
Conversation
@mykola-mokhnach thanks for the suggestions. I refactored things a bit, please re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Could you address mjpegServerPort
in https://github.com/appium/appium/blob/master/docs/en/writing-running-appium/caps.md#uiautomator2-only and https://github.com/appium/appium/blob/master/docs/en/advanced-concepts/parallel-tests.md later?
appium-uiautomator2-driver@1.52.0 |
This change-set exposes the
mjpegServerPort
capability and starts / stops the ADB bind(s) / release(s) alongside the{device,system}Port
bind / release.This is related to PRs: appium/appium-uiautomator2-server#340 and appium/appium#14203 which were merged earlier this week.
Thank you for reviewing.