Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Get Installed and System Apps Info #585

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

shashank2086
Copy link

Getting all Installed and System apps of your device with Name and Main Activity for easily selecting and starting automation of any Application.

* */

commands.mobileGetAppsInfo = async function () {
return await this.jwproxy.command('/appium/device/apps', 'GET', {});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please test your PRs before publishing them. This call won't work as jwproxy only supports in-session endpoints and the session/<id> prefix will be automatically added to it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes got it

@shashank2086
Copy link
Author

Why functional test failed?

@mykola-mokhnach
Copy link
Contributor

Why functional test failed?

It seems to be a CI issue, retry could help

@shashank2086 Do you have time to finish this PR?

@shashank2086
Copy link
Author

For this CI issue right?

@mykola-mokhnach
Copy link
Contributor

For this CI issue right?

No, I mean to finish the work on this PR.
What needs to be done:

  • The minimum version of appium-uiautomator2-server package should be bumped
  • Code formatitng
  • Documentation (in code and in readme)

Check, for example, #530

@shashank2086
Copy link
Author

For this CI issue right?

No, I mean to finish the work on this PR. What needs to be done:

  • The minimum version of appium-uiautomator2-server package should be bumped
  • Code formatitng
  • Documentation (in code and in readme)

Check, for example, #530

Okay got it

updated README
lib/commands/apps.js Outdated Show resolved Hide resolved
lib/commands/apps.js Outdated Show resolved Hide resolved
formatting

Co-authored-by: Kazuaki Matsuo <fly.49.89.over@gmail.com>
@KazuCocoa
Copy link
Member

The minimum version of appium-uiautomator2-server package should be bumped

is remaining. https://github.com/appium/appium-uiautomator2-driver/blob/master/package.json#L63

README.md Outdated
@@ -418,6 +418,20 @@ Retrieves the information about the device under test, like the device model, se

The extension returns a dictionary whose entries are the device properties. Check https://github.com/appium/appium-uiautomator2-server/blob/master/app/src/main/java/io/appium/uiautomator2/handler/GetDeviceInfo.java to get the full list of returned keys and their corresponding values.

### mobile: getPackages

Retrieves the information about the installed packages with its respective launchable activity.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also mention that package without launchable activities are not added to the list

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

let extensions = {}, commands = {};

/**
* Gets system and installed applications info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format the docstring properly according to jsdoc documentation rules. For example the @return section must be present. Check docs for other extansions for examples

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants