-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch XPath engine to Jaxen/JDOM2 #237
Conversation
app/src/main/java/io/appium/uiautomator2/core/AccessibilityNodeInfoDumper.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
I have also added a separate setting to enable unicode transliteration for class names: |
.replaceAll("[$@#&]", ".") | ||
.replaceAll("\\.+", ".") | ||
.replaceAll("(^\\.|\\.$)", ""); | ||
|
||
if (((NormalizeTagNames) Settings.NORMALIZE_TAG_NAMES.getSetting()).getValue()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we apply this replacement for espresso driver as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to do any preliminary optimizations yet. The way class names are retrieved by espresso is different from UIA, so it might be there is no such problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I see > The way class names are retrieved by espresso is different from UIA
thanks!
Another try to address appium/appium#11854