Switch XPath engine to Jaxen/JDOM2 #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
reviewed
Dec 18, 2018
app/src/main/java/io/appium/uiautomator2/core/AccessibilityNodeInfoDumper.java
Outdated
Show resolved
Hide resolved
imurchie
approved these changes
Dec 18, 2018
dpgraham
approved these changes
Dec 18, 2018
|
I have also added a separate setting to enable unicode transliteration for class names: |
KazuCocoa
reviewed
Dec 19, 2018
| .replaceAll("[$@#&]", ".") | ||
| .replaceAll("\\.+", ".") | ||
| .replaceAll("(^\\.|\\.$)", ""); | ||
|
|
||
| if (((NormalizeTagNames) Settings.NORMALIZE_TAG_NAMES.getSetting()).getValue()) { |
There was a problem hiding this comment.
Should we apply this replacement for espresso driver as well?
There was a problem hiding this comment.
I don't want to do any preliminary optimizations yet. The way class names are retrieved by espresso is different from UIA, so it might be there is no such problem.
There was a problem hiding this comment.
ah, I see > The way class names are retrieved by espresso is different from UIA
thanks!
imurchie
approved these changes
Dec 19, 2018
4 tasks
9 tasks
rajdeepv
pushed a commit
to rajdeepv/appium-uiautomator2-server
that referenced
this pull request
Jan 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another try to address appium/appium#11854