Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only wait for idle once on find #279

Merged
merged 2 commits into from
May 31, 2019
Merged

Only wait for idle once on find #279

merged 2 commits into from
May 31, 2019

Conversation

imurchie
Copy link
Contributor

Each find called ended up calling Device.waitForIdle three times, which is not necessary. Also make use of the waitForIdleTimeout.

This has been tested with the appium-uiautomator2-driver as well (https://travis-ci.org/appium/appium-uiautomator2-driver/builds/539680318).

mykola-mokhnach
mykola-mokhnach approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@imurchie imurchie changed the title Only wait foridle once on find Only wait for idle once on find May 31, 2019
@imurchie imurchie merged commit 175baab into master May 31, 2019
@imurchie imurchie deleted the isaac-wait-for-idle branch May 31, 2019 17:07
@mykola-mokhnach mykola-mokhnach mentioned this pull request Jun 6, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlipps jlipps jlipps approved these changes

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@imurchie @jlipps @mykola-mokhnach