refactor: Align orientation and rotation terms #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linking appium/appium#11663 |
mykola-mokhnach
changed the title
|
Complexity increasing per file
==============================
- app/src/main/java/io/appium/uiautomator2/handler/GetOrientation.java 2
- app/src/main/java/io/appium/uiautomator2/model/ScreenRotation.java 7
- app/src/main/java/io/appium/uiautomator2/handler/SetOrientation.java 2
- app/src/main/java/io/appium/uiautomator2/model/settings/UseResourcesForOrientationDetection.java 1
Complexity decreasing per file
==============================
+ app/src/main/java/io/appium/uiautomator2/model/ScreenOrientation.java -2
See the complete overview on Codacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UiAutomator only operates the term of
Rotation, which reflects the current rotation value of the device display. However, the spec does not actually require that zero degrees rotation value is a portrait orientation, which might be the case for some devices. In such case the value returned for GetOrientation command would not be the one, that is naturally expected.In this PR we try to workaround that issue by matching the actual orientation value retrieved from instrumentation context resources configuration with the actual rotation value if the
useResourcesForOrientationDetectionsetting is set totrue(by default it isfalseto avoid issues with current automation scripts).