Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: browserName for selenium-appium compatibility #88

Merged

Conversation

jaimecbernardo
Copy link

Add browserName to the desiredCapConstraints for compatibility with selenium-appium, since selenium-webdriver requires that browserName is present, so selenium-appium must provide it in capabilities.

Without the fix, we get the current error when trying to run react-native-windows application tests:

[BaseDriver] The following capabilities were provided, but are not recognized by Appium:
[BaseDriver]   browserName

Refs:

Note: There still seems to be more compatibility issues between selenium-appium and the 1.15.0 release of appium-windows-driver, but those are still being investigated.

Add browserName to the desiredCapConstraints for compatibility with
selenium-appium, since selenium-webdriver requires that browserName is
present, so selenium-appium must provide it in capibilities.
@jsf-clabot
Copy link

jsf-clabot commented Oct 27, 2020

CLA assistant check
All committers have signed the CLA.

@mykola-mokhnach
Copy link

Thanks @jaimecbernardo

It is nice to see that Microsoft is still supporting the project, since we recently haven't heard any news from the WinAppDriver team and the project itself was looking more dead than alive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants