Use appium-ios-device instead of idevicesyslog
#1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imurchie
reviewed
Jul 3, 2019
lib/device-log/ios-simulator-log.js
Outdated
| firstLine = false; | ||
| } | ||
| } else { | ||
| this.logRow += stdout; |
There was a problem hiding this comment.
there might be a potential memory leak
There was a problem hiding this comment.
This should be fine. The code already runs in appium-ios-driver for years. I wan't to clean it up later
lib/device-log/ios-simulator-log.js
Outdated
| onOutput (prefix = '') { | ||
| const logs = this.logRow.split('\n'); | ||
| onOutput (logRow, prefix = '') { | ||
| const logs = _.cloneDeep(logRow).split('\n'); |
There was a problem hiding this comment.
I'd rather clone the result of split, because internally string.split does not create new string instances, but rather pointers to the original big string (which prevents it to be garbage collected if at least one of these slices is still used somewhere)
umutuzgur
force-pushed
the
use_ios_device_syslog
branch
from
e22f3c8
to
acefab6
Compare
| xcodeVersion: this.xcodeVersion, | ||
| }); | ||
|
|
||
| if (this.isRealDevice()) { |
There was a problem hiding this comment.
a ternary operator might take less lines of code ;)
mykola-mokhnach
approved these changes
Jul 9, 2019
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
appium-ios-driverappium-ios-deviceTODO
realDeviceLoggercapability completely