feat: Remove ifuse pull #1019
feat: Remove ifuse pull #1019
Conversation
|
@KazuCocoa I tested it with the |
| @@ -15,32 +14,11 @@ const CONTAINER_PATH_PATTERN = new RegExp(`^${CONTAINER_PATH_MARKER}([^/]+)/(.*) | |||
| const CONTAINER_TYPE_SEPARATOR = ':'; | |||
| const IFUSE_CONTAINER_DOCUMENTS = 'documents'; | |||
| const CONTAINER_DOCUMENTS_PATH = 'Documents'; | |||
| const IO_TIMEOUT = 30000; | |||
There was a problem hiding this comment.
I'd say the timeout to 5 minutes or even more. Folders can be quite large in size
There was a problem hiding this comment.
@mykola-mokhnach 30 seconds should be fine. It is also crazy that we map the folders into a buffer in node. How much memory do we consume then?
There was a problem hiding this comment.
at least the same amount that the content of zipped folder would consume. Although, I don't have any better solution for that since selenium API does not implement streamed downloads. We must keep everything in memory, convert into base64-string and then put into the response body
There was a problem hiding this comment.
with maximum speed of USB2.0 connection of about 40MB/s we could download 1.2 GB within 30 seconds. Appium's limit of request body size is 1GB. Yeah, this should suffice :)
| await mkdirp(folderPath); | ||
| const promises = []; | ||
| await service.walkDir(relativePath, true, async (itemPath, isDir) => { | ||
| const pathOnServer = path.join(tmpFolder, itemPath); |
There was a problem hiding this comment.
path.posix.join
Explanation:
The path module is platform dependent. So for example, if the code is running on Windows, the path separater is always a backslash, which is not acceptable on iOS/Android, where a normal slash is used. That is why it is always safe to explicitly set path.posix, so the target path is constructed properly independently of the host OS
There was a problem hiding this comment.
@mykola-mokhnach I'm aware of that. I left it path.join since the appium server can be run also on windows. I can change it to posix if we want to
There was a problem hiding this comment.
@mykola-mokhnach Should I do it? I'm confused if I should or not do it atm
There was a problem hiding this comment.
This should be done if path module is used to construct/handle paths on the target phone. If we are handling paths on the local file system where the Appium server is running then everything is fine
| try { | ||
| await closeEvent; | ||
| } catch (e) { | ||
| throw new Error(`Couldnt push the file within the given timeout ${IO_TIMEOUT}ms`); |
There was a problem hiding this comment.
When I tried to upload a big file, 50mb, then could observe below messages on appium server.
Should we handle them? (just a confirmation/)
Failed to receive any data within the timeout: 10000 happened
JQCK4WucYrQMzUMwCSeNQwyGw...
[debug] [XCUITest] Executing command 'pushFile'
[debug] [XCUITest] Parsed container type: documents
(node:76465) UnhandledPromiseRejectionWarning: Error: Failed to receive any data within the timeout: 10000
at Timeout.setTimeout (/Users/kazu/GitHub/appium-xcuitest-driver/node_modules/appium-ios-device/lib/afc/index.js:255:31)
at ontimeout (timers.js:436:11)
at tryOnTimeout (timers.js:300:5)
at listOnTimeout (timers.js:263:5)
at Timer.processTimers (timers.js:223:10)
(node:76465) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:76465) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:76465) UnhandledPromiseRejectionWarning: Error: Failed to receive any data within the timeout: 10000
at Timeout.setTimeout (/Users/kazu/GitHub/appium-xcuitest-driver/node_modules/appium-ios-device/lib/afc/index.js:255:31)
at ontimeout (timers.js:436:11)
at tryOnTimeout (timers.js:300:5)
at listOnTimeout (timers.js:263:5)
at Timer.processTimers (timers.js:223:10)
(node:76465) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
[debug] [W3C (42d14ed6)] Encountered internal error running command: Error: Couldnt push the file within the given timeout 30000ms
[debug] [W3C (42d14ed6)] at pushFileToRealDevice (/Users/kazu/GitHub/appium-xcuitest-driver/lib/commands/file-movement.js:237:13)
[HTTP] <-- POST /wd/hub/session/42d14ed6-3f16-4281-acce-554ad11aad3a/appium/device/push_file 500 32452 ms - 587
Pushed file was fine
No description provided.