refactor: Remove idevicescreenshot since don't need it #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umutuzgur
force-pushed
the
remove_idevicescreenshot
branch
from
8b6a518
to
9b3fe5a
Compare
imurchie
reviewed
Jul 30, 2019
|
Let me do a load test |
|
@imurchie WDA screenshot code doesn't work with iOS versions below 11. I need to fix that first apparently but then it is reliable |
|
Alrighty. Should we hold off on this until that can be done? |
|
@umutuzgur Appium does not support Xcode8 (and iOS10, which is based on it) since quite a while. |
|
@imurchie Can you confirm this? I should probably communicate this internally then |
umutuzgur
force-pushed
the
remove_idevicescreenshot
branch
from
9b3fe5a
to
9fdefa8
Compare
|
@imurchie The fix is merged in WDA. All looks good now and we can proceed with this PR |
imurchie
approved these changes
Aug 2, 2019
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm suggesting removing
idevicescreenshotif it is no longer needed