chore: add pushing and installation profiling logic #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try { | ||
| const bundlePathOnPhone = await this.pushAppBundle(app); | ||
| await this.installApplcation(bundlePathOnPhone); | ||
| log.info(`Installation is successful after ${new Date() - start}ms`); |
There was a problem hiding this comment.
I usually prefer to use process.hrtime for performance measurement
There was a problem hiding this comment.
we don't know if the installation is successful, since this.installApplcation (btw there is a type in the method name) continues even after a timeout happens
There was a problem hiding this comment.
That is successful for us. The phones are something flaky and don't notify you back this happens really rarely so I let that slide and call it also successful
mykola-mokhnach
approved these changes
Aug 5, 2019
jlipps
reviewed
Aug 5, 2019
| try { | ||
| const bundlePathOnPhone = await this.pushAppBundle(app); | ||
| await this.installApplcation(bundlePathOnPhone); | ||
| await this.installApplication(bundlePathOnPhone); | ||
| log.info(`Installation is successful after ${new Date() - start}ms`); |
There was a problem hiding this comment.
we already have a metrics tracking system, so you don't have to do this manually. see BaseDriver::logEvent. You could log an install start and install finish event.
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.