fix: catching error when no available web pages #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
changed the title
lib/commands/context.js
Outdated
| @@ -158,7 +158,12 @@ extensions.listWebFrames = async function listWebFrames (useUrl = true) { | |||
| let pageArray; | |||
There was a problem hiding this comment.
I'd rather assign it to [] here
imurchie
approved these changes
Aug 7, 2019
lib/commands/context.js
Outdated
| @@ -155,14 +155,13 @@ extensions.listWebFrames = async function listWebFrames (useUrl = true) { | |||
| log.debug(`Selecting by url: ${useUrl} ${useUrl ? `(expected url: '${this.getCurrentUrl()}')` : ''}`); | |||
|
|
|||
| const currentUrl = useUrl ? this.getCurrentUrl() : undefined; | |||
| let pageArray; | |||
| let pageArray = []; | |||
| if (this.remote && this.remote.appIdKey) { | |||
| // already connected | |||
| try { | |||
| pageArray = await this.remote.selectApp(currentUrl, this.opts.webviewConnectRetries, this.opts.ignoreAboutBlankUrl); | |||
| } catch (err) { | |||
| log.debug(`No available web pages: ${err}`); | |||
There was a problem hiding this comment.
perhaps err.message ?
lib/commands/context.js
Outdated
| @@ -168,7 +172,11 @@ extensions.listWebFrames = async function listWebFrames (useUrl = true) { | |||
| log.debug('Unable to connect to the remote debugger.'); | |||
| return []; | |||
| } | |||
| pageArray = await this.remote.selectApp(currentUrl, this.opts.webviewConnectRetries, this.opts.ignoreAboutBlankUrl); | |||
| try { | |||
There was a problem hiding this comment.
this whole block can be moved to a separate local function/closure to avoid duplication
KazuCocoa
changed the title
mykola-mokhnach
approved these changes
Aug 7, 2019
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
* fix: catching error when no available web pages * set [] by default * define local func
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, https://github.com/appium/appium-remote-debugger/blob/b8f5be6bd0fe9577c0f3ca54eac595a049e7aaaa/lib/remote-debugger.js#L324 is rased when we run below scenario.
available contextscommandNATIVE_APP馃啑Web Viewcellavailable contextscommandNATIVE_APPandWEBVIEW_xxxx馃啑available contextscommandThis is because we do not handle the error in xcuitest layer.
The error means we have no available webview. So, I think we can make the result
[]In this PR, I handle the error as try/catch in xcuitest layer, but I also wonder we can return
[]in https://github.com/appium/appium-remote-debugger/blob/b8f5be6bd0fe9577c0f3ca54eac595a049e7aaaa/lib/remote-debugger.js#L324@imurchie
Do you have any good idea how to handle the issue?
try/catch in xcuitest layer like this PR, return
[]in the remote debugger or other good ideas...