fix: start proxy before WDA to handle caching issues #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
approved these changes
Aug 27, 2019
|
Please merge after the tests are finished |
KazuCocoa
approved these changes
Aug 27, 2019
| return; | ||
| } | ||
| if (isLocalHost(this.wdaBaseUrl)) { | ||
| this.iproxy = await this.createIProxy(); |
There was a problem hiding this comment.
the next step might be to add better error handling to createIProxy, so we can suggest which process to kill in order to free up the port
There was a problem hiding this comment.
The next step is creating a Factory class to handle the cached WDA instances more properly
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.