feat: switch reduce motion via settings API #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/driver.js
Outdated
| * @param {?boolean} motion Wether enable reduceMotion | ||
| */ | ||
| async setReduceMotion (motion) { | ||
| if (this.isSimulator()) { |
There was a problem hiding this comment.
if (this.isRealDevice() || !_.isBoolean(isEnabled)) {
return;
}
...
lib/driver.js
Outdated
| /** | ||
| * Set reduceMotion as 'motion' or set false if no 'reduceMotion' in capabilities. | ||
| * It works only on simulator. | ||
| * @param {?boolean} motion Wether enable reduceMotion |
There was a problem hiding this comment.
how about isEnabled?
lib/driver.js
Outdated
| @@ -1146,6 +1143,19 @@ class XCUITestDriver extends BaseDriver { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Set reduceMotion as 'motion' or set false if no 'reduceMotion' in capabilities. | |||
| * It works only on simulator. | |||
There was a problem hiding this comment.
I'd rather say - the call is ignored for real devices
lib/driver.js
Outdated
| return; | ||
| } | ||
|
|
||
| log.info(`set reduceMotion to ${isEnabled}`); |
mykola-mokhnach
approved these changes
Sep 7, 2019
10 tasks
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
…r pref (appium#1065) * Call settins api to reduceMotion instead of changing simulator config * extract setReduceMotion * bump wda version * fix review, set false by default * ignore reduceMotion when no reduceMotion is in caps * tweak log wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to appium/WebDriverAgent#202
Before:
After: