Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fallback to ios-deploy usage if ios-device lib fails to install the app bundle #1098

Merged
merged 4 commits into from
Oct 28, 2019

Conversation

mykola-mokhnach
Copy link
Contributor

It seems like there are still some cases where ios-device caanot handle app installation properly but ios-deploy can. So, we can make the flow more flexible

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the ios-deploy worked with inserting raising an error in L37-39.

@mykola-mokhnach mykola-mokhnach merged commit cfbd469 into appium:master Oct 28, 2019
@mykola-mokhnach mykola-mokhnach deleted the deploy_fallback branch October 28, 2019 06:31
khanayan123 pushed a commit to khanayan123/appium-xcuitest-driver that referenced this pull request May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants