feat: add additionalWebviewBundleIds capability #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/desired-caps.js
Outdated
| @@ -192,6 +192,9 @@ let desiredCapConstraints = _.defaults({ | |||
| includeSafariInWebviews: { | |||
| isBoolean: true | |||
| }, | |||
| additionalWebviewBundleIds: { | |||
| isArray: true | |||
There was a problem hiding this comment.
I'm thinking about making it a comma separated string instead. I see people sometimes having problems poviding arrays to caps, especially in Java
| @@ -70,6 +70,7 @@ extensions.getNewRemoteDebugger = async function getNewRemoteDebugger () { | |||
| } | |||
| return createRemoteDebugger({ | |||
| bundleId: this.opts.bundleId, | |||
| additionalBundleIds: this.opts.additionalWebviewBundleIds, | |||
There was a problem hiding this comment.
this.opts.additionalWebviewBundleIds || [] ?
There was a problem hiding this comment.
This is done on the remote debugger side.
imurchie
force-pushed
the
isaac-additional-webview-bundleids
branch
from
e969516
to
5950d23
Compare
KazuCocoa
approved these changes
Dec 8, 2019
| @@ -192,6 +192,10 @@ let desiredCapConstraints = _.defaults({ | |||
| includeSafariInWebviews: { | |||
| isBoolean: true | |||
| }, | |||
| additionalWebviewBundleIds: { | |||
| // recognize the capability | |||
| // but validate in driver#validateDesiredCaps | |||
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
* feat: add additionalWebviewBundleIds capability * fix: allow JSON array for cap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass additional webview bundle identifiers along to the remote debugger.