feat: add option for wait duration for mobile context list #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/commands/context.js
Outdated
| return await this.getContexts(); | ||
| } | ||
|
|
||
| while (timer.getDuration().asMilliSeconds < waitForWebviewMs) { |
There was a problem hiding this comment.
I'd rather use waitForCondition
There was a problem hiding this comment.
That would require an external variable anyway, and be annoying. Also exceptions for control flow are... unneeded.
There was a problem hiding this comment.
ok, we anyway need to call getContexts() at least once.
How about:
let contexts = await this.getContexts();
while (timer.getDuration().asMilliSeconds < waitForWebviewMs) {
log.debug('Retrieving contexts');
contexts = await this.getContexts();
if (contexts.length >= 2) {
log.debug(`Found webview context after ${timer.getDuration().asMilliSeconds.toFixed(0)}ms`);
return contexts;
}
log.debug(`No webviews found in ${timer.getDuration().asMilliSeconds.toFixed(0)}ms`);
}
return contexts;
mykola-mokhnach
approved these changes
Jan 2, 2020
KazuCocoa
approved these changes
Jan 3, 2020
10 tasks
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
* feat: add option for wait duration for mobile context list * return an array * make sure getting contexts happens once
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option,
waitForWebviewMs, to the mobile execute version ofgetContexts, which will make it blocking for that period of time. Workaround for appium/appium#13770