Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure appPushTimeout is used for installApp #1138

Merged
merged 1 commit into from
Jan 6, 2020
Merged

fix: make sure appPushTimeout is used for installApp #1138

merged 1 commit into from
Jan 6, 2020

Conversation

imurchie
Copy link
Contributor

@imurchie imurchie commented Jan 3, 2020

Use the appPushTimeout in installApp.

@mykola-mokhnach
Copy link
Contributor

What is the reason to have this?

@imurchie
Copy link
Contributor Author

imurchie commented Jan 6, 2020

If you try to use install_app to install a big app and it times out, it reports that you ought to change the appPushTimeout cap, but it does nothing currently.

@imurchie imurchie merged commit 85a3071 into appium:master Jan 6, 2020
@imurchie imurchie deleted the isaac-mobileinstall-timeout branch January 6, 2020 20:26
khanayan123 pushed a commit to khanayan123/appium-xcuitest-driver that referenced this pull request May 10, 2021
@imurchie
fix: make sure appPushTimeout is used for installApp (appium#1138)
35a0a4f
@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@imurchie @mykola-mokhnach