feat: Add mobile commands to cover new simctl features #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgraham
reviewed
Feb 11, 2020
lib/commands/appearance.js
Outdated
| return this.isSimulator() | ||
| ? await this.opts.device.setAppearance(style) | ||
| // ugly workaround for real devices | ||
| : await this.mobileSiriCommand({ |
There was a problem hiding this comment.
Can the mobileSiriCommand workaround be used on simulators with Xcode < 11.4 ?
There was a problem hiding this comment.
yes, we can try it
dpgraham
approved these changes
Feb 11, 2020
KazuCocoa
approved these changes
Feb 12, 2020
| @@ -84,6 +84,10 @@ extensions.executeMobile = async function executeMobile (mobileCommand, opts = { | |||
| clearKeychains: 'mobileClearKeychains', | |||
|
|
|||
| getPermission: 'mobileGetPermission', | |||
| setPermission: 'mobileSetPermissions', | |||
There was a problem hiding this comment.
What about changePermissions like Android?
(I also thought to keep setPermissions for iOS since the parameter was different. So, it is fine to go with current name, too.)
10 tasks
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.