-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add mobile command for tapWithNumberOfTaps #1184
Conversation
@@ -9,6 +9,29 @@ let helpers = {}, extensions = {}, commands = {}; | |||
|
|||
commands.moveTo = iosCommands.gesture.moveTo; | |||
|
|||
|
|||
function requireFloatParameter (paramName, paramValue, methodName) { | |||
if (_.isUndefined(paramValue)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check (and the one in requireIntParameter
) seems unnecessary. parseFloat(undefined)
returns NaN
, so it would be caught in the isNaN
check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to show different error messages for missing and incorrect parameter values
scroll: 'mobileScroll', | ||
// https://developer.apple.com/documentation/xctest/xcuielement/1618668-swipeleft?language=objc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 > links
Hi @mykola-mokhnach, are you planning to add any documentation or tests for this? Reason I am asking this question is to better understand how and where to use this. |
@jineshqa No, I don't plan to add more docs than we already have in https://github.com/appium/appium/blob/master/docs/en/writing-running-appium/ios/ios-xctest-mobile-gestures.md#mobile-tapwithnumberoftaps |
Thanks @mykola-mokhnach. I swear, I googled and searched GitHub repo before posting here and could not find the above link. Thanks again for kindly sharing the link. |
Based on appium/WebDriverAgent#295