Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add mobile command for tapWithNumberOfTaps #1184

Merged
merged 3 commits into from
Mar 24, 2020

Conversation

mykola-mokhnach
Copy link
Contributor

@@ -9,6 +9,29 @@ let helpers = {}, extensions = {}, commands = {};

commands.moveTo = iosCommands.gesture.moveTo;


function requireFloatParameter (paramName, paramValue, methodName) {
if (_.isUndefined(paramValue)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check (and the one in requireIntParameter) seems unnecessary. parseFloat(undefined) returns NaN, so it would be caught in the isNaN check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to show different error messages for missing and incorrect parameter values

scroll: 'mobileScroll',
// https://developer.apple.com/documentation/xctest/xcuielement/1618668-swipeleft?language=objc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 > links

@jineshqa
Copy link

jineshqa commented Jun 1, 2020

Hi @mykola-mokhnach, are you planning to add any documentation or tests for this? Reason I am asking this question is to better understand how and where to use this.

@mykola-mokhnach
Copy link
Contributor Author

@jineshqa
Copy link

jineshqa commented Jun 1, 2020

Thanks @mykola-mokhnach. I swear, I googled and searched GitHub repo before posting here and could not find the above link. Thanks again for kindly sharing the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants