feat: Add mobile commands for audio recording #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I did belw input, the input device (iPhone) was recoded Note: We must allow microphone permission (My case was via iTerm.app)
|
KazuCocoa
reviewed
May 10, 2020
|
|
||
| const commands = {}; | ||
|
|
||
| const AUDIO_RECORD_FEAT_NAME = 'audio_record'; |
There was a problem hiding this comment.
👍
Can add the item in https://github.com/appium/appium-xcuitest-driver#opt-in-features-with-security-risk
| if (!audioInput) { | ||
| log.errorAndThrow(`The mandatory audioInput option is not provided. Please set it ` + | ||
| `to a correct value (e. g. ':1'). Use 'ffmpeg -f avfoundation -list_devices true -i ""' ` + | ||
| `command to list available input sources`); |
There was a problem hiding this comment.
It would be nice to log the url, https://www.ffmpeg.org/ffmpeg-devices.html#avfoundation , for iPhone device to check the device audio input format
There was a problem hiding this comment.
We do log the output of ffmpeg
KazuCocoa
approved these changes
May 10, 2020
niiice. Many thanks for checking it |
dpgraham
approved these changes
May 10, 2020
|
This is awesome! |
|
The limitation of MIDI connect. Probably we cannot customise the name of below iPhone name (even via Audio MIDI Setup app in macOS). I could not find the method yet. Haven't tested yet, but for real devices, maybe we can record audio with multiple devices if all devices appear as the result of |
KazuCocoa
approved these changes
May 10, 2020
4 tasks
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of this PR is that we could record Simulator audio output using Soundflower like it is described in http://www.lorisware.com/blog/2012/04/28/recording-iphone-emulator-video-with-sound/
For real devices there is a possibility to connect a phone as an input device: https://www.makeuseof.com/tag/play-audio-iphone-mac/, although I've never tested that, since I don't have a real device :-P
In the worst case one could always use the classic audio jack connected to a microphone input of a mac machine.
The feature is insecure, because it allows to access system microphone, so it must be enabled explicitly on the server side.
I'll write a separate doc later on how to configure the Simulator for audio recording. It would be great if @KazuCocoa could help to check how audio capture works with real devices, so we have a complete documentation on the feature.
cc @dpgraham