Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support getGeoLocation (requires 'Always' in Location Services) #1266

Merged
merged 6 commits into from
Jan 18, 2021

Conversation

KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented Jan 17, 2021

When it worked:

driver.location
=> #<struct Selenium::WebDriver::Location latitude=55, longitude=0.72, altitude=0>

Against tvOS:

> @driver.location
Selenium::WebDriver::Error::UnsupportedOperationError: unsupported
from UnsupportedOperationError: unsupported

// '3' is 'Always' in the privacy
// https://developer.apple.com/documentation/corelocation/clauthorizationstatus
if (authorizationStatus !== 3) {
log.errorAndThrow(`Location service must be 'Always'. Please set it up manually via ` +
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach Jan 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must be set to 'Always' in order to retrieve the current geolocation data

@KazuCocoa KazuCocoa merged commit bedb974 into appium:master Jan 18, 2021
@KazuCocoa KazuCocoa deleted the add-location branch January 18, 2021 16:39
github-actions bot pushed a commit that referenced this pull request Jan 18, 2021
# [3.34.0](v3.33.1...v3.34.0) (2021-01-18)

### Features

* support getGeoLocation (requires 'Always' in Location Services) ([#1266](#1266)) ([bedb974](bedb974))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 3.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

khanayan123 pushed a commit to khanayan123/appium-xcuitest-driver that referenced this pull request May 10, 2021
khanayan123 pushed a commit to khanayan123/appium-xcuitest-driver that referenced this pull request May 10, 2021
# [3.34.0](appium/appium-xcuitest-driver@v3.33.1...v3.34.0) (2021-01-18)

### Features

* support getGeoLocation (requires 'Always' in Location Services) ([appium#1266](appium#1266)) ([bedb974](appium@bedb974))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants