feat: CSS selector for iOS #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would make sense to add this locator to README |
|
@mykola-mokhnach the README.md doesn't talk about selectors. I'll add this to the Appium site docs. |
KazuCocoa
reviewed
Jan 31, 2021
| @@ -0,0 +1,61 @@ | |||
| import chai from 'chai'; | |||
| */ | ||
| function parsePseudo (cssPseudo) { | ||
| if (cssPseudo.valueType && cssPseudo.valueType !== 'string') { | ||
| throw new Error(`'${cssPseudo.name}=${cssPseudo.value}'. ` + |
| iosClassChainSelector += `/${parseCssRule(cssRule.rule)}`; | ||
| } | ||
|
|
||
| if (cssRule.nestingOperator === '>') { |
There was a problem hiding this comment.
how about using a ternary operator?
| if (cssRule.nestingOperator === '>') { | ||
| return iosClassChainSelector; | ||
| } else { | ||
| return `**/` + iosClassChainSelector; |
There was a problem hiding this comment.
`**/${iosClassChainSelector}`
mykola-mokhnach
approved these changes
Feb 1, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Feb 1, 2021
# [3.36.0](v3.35.1...v3.36.0) (2021-02-01) ### Features * CSS selector for iOS ([#1274](#1274)) ([047d3a8](047d3a8))
|
🎉 This PR is included in version 3.36.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
# [3.36.0](appium/appium-xcuitest-driver@v3.35.1...v3.36.0) (2021-02-01) ### Features * CSS selector for iOS ([appium#1274](appium#1274)) ([047d3a8](appium@047d3a8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copies the same logic as what was done in UiAutomator2 Driver but makes some changes to make it work with iOS Class Chain.