feat: add appium:includeDeviceCapsToSessionInfo to be able to ignore /screen call to WDA #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
changed the title
lib/desired-caps.js
Outdated
| @@ -239,6 +239,9 @@ let desiredCapConstraints = _.defaults({ | |||
| safariIgnoreWebHostnames: { | |||
| isString: true, | |||
| }, | |||
| includeScreenInfoInSession: { | |||
There was a problem hiding this comment.
should the name also be updated here?
mykola-mokhnach
approved these changes
Feb 12, 2021
|
yea, highly agree with you |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 12, 2021
# [3.37.0](v3.36.1...v3.37.0) (2021-02-12) ### Features * add appium:includeDeviceCapsToSessionInfo to be able to ignore /screen call to WDA ([#1278](#1278)) ([14e1189](14e1189))
|
🎉 This PR is included in version 3.37.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
…/screen call to WDA (appium#1278) * feat: add includeScreenInfoInSession to be able to ignore /screen call to WDA * fix review * fix desired-caps
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
# [3.37.0](appium/appium-xcuitest-driver@v3.36.1...v3.37.0) (2021-02-12) ### Features * add appium:includeDeviceCapsToSessionInfo to be able to ignore /screen call to WDA ([appium#1278](appium#1278)) ([14e1189](appium@14e1189))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For appium/appium#15101
In some environments, it seems
/screenendpoint takes long time to get the response in XCTest.As a workaround for now, we can disable the call.
We can call them via an extension like
mobile:screenInfoor existingdeviceInfo?