Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add mobile extension for the 'expectNotification' call #1287

Merged
merged 1 commit into from
Mar 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,21 @@ Name | Type | Required | Description | Example
bundleId | string | yes | The bundle identifier of the target application | com.apple.Preferences
payload | map | yes | Valid Apple Push Notification values. Read the `Create the JSON Payload` topic of the [official Apple documentation](https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/generating_a_remote_notification?language=objc) for more details on the payload creation. | `{"aps": {"alert": "This is a simulated notification!", "badge": 3, "sound": "default"} }`

### mobile: expectNotification

Blocks until the expected notification is delivered.
It is a thin wrapper over [XCTNSNotificationExpectation](https://developer.apple.com/documentation/xctest/xctnsnotificationexpectation?language=objc) and
[XCTDarwinNotificationExpectation](https://developer.apple.com/documentation/xctest/xctdarwinnotificationexpectation?language=objc) entities.
The extension call throws [TimeoutError](https://www.selenium.dev/selenium/docs/api/javascript/module/selenium-webdriver/lib/error_exports_TimeoutError.html) if the expected notification has not been delivered within the given timeout.

#### Arguments

Name | Type | Required | Description | Example
--- | --- | --- | --- | ---
name | string | yes | The name of the notification to expect | com.example.fooAllDone
type | string | no | Which notification type to expect. Either `plain` (the default value) to wait for a notification from the *default* notification center or `darwin` to wait for a system notification. | darwin
timeoutSeconds | number | no | For how long to wait until the notification is delivered in float seconds. 60 seconds by default | 5.5

### mobile: enrollBiometric

Enrolls biometric authentication on Simulator.
Expand Down
1 change: 1 addition & 0 deletions lib/commands/execute.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ extensions.executeMobile = async function executeMobile (mobileCommand, opts = {
listXCTestsInTestBundle: 'mobileListXCTestsInTestBundle',

pushNotification: 'mobilePushNotification',
expectNotification: 'mobileExpectNotification',
};

if (!_.has(commandMap, mobileCommand)) {
Expand Down
29 changes: 29 additions & 0 deletions lib/commands/notifications.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,33 @@ extensions.mobilePushNotification = async function mobilePushNotification (opts
});
};


/**
* @typedef {Object} NotificationExpectationOptions
*
* @property {!string} name - The name of the notification to expect
* @property {?string} type [plain] - Which notification type to expect.
* Either 'plain' to wait for a notification from the default notification center or 'darwin'
* to wait for a system notification.
* @property {number} timeoutSeconds [60] - For how long to wait until the notification is delivered
* in float seconds.
*/

/**
* Blocks until the expected notification is delivered.
* This method is a thin wrapper over XCTNSNotificationExpectation and
* XCTDarwinNotificationExpectation entities.
*
* @param {NotificationExpectationOptions} opts
* @throws TimeoutError if the expected notification has not been delivered within the given timeout
*/
extensions.mobileExpectNotification = async function mobileExpectNotification (opts = {}) {
const { name, type, timeoutSeconds } = opts;
return await this.proxyCommand('/wda/expectNotification', 'POST', {
name,
type,
timeout: timeoutSeconds,
});
};

export default extensions;
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"appium-ios-simulator": "^3.25.1",
"appium-remote-debugger": "^8.13.2",
"appium-support": "^2.47.1",
"appium-webdriveragent": "^3.0.0",
"appium-webdriveragent": "^3.4.0",
"appium-xcode": "^3.8.0",
"async-lock": "^1.0.0",
"asyncbox": "^2.3.1",
Expand Down