-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Control the visibility of the Tab Bar and Smart App Banner #1345
Merged
mykola-mokhnach
merged 9 commits into
appium:master
from
zcmgyu:improve-nativewebtapstrict
Oct 29, 2021
Merged
feat: Control the visibility of the Tab Bar and Smart App Banner #1345
mykola-mokhnach
merged 9 commits into
appium:master
from
zcmgyu:improve-nativewebtapstrict
Oct 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcmgyu
commented
Oct 26, 2021
zcmgyu
commented
Oct 26, 2021
const durationWithoutIgnore = end1 - start1; | ||
|
||
const start2 = performance.now(); | ||
await driver.updateSettings({ nativeWebTapSmartAppBannerVisible: false }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the smart app banner is not visible.
KazuCocoa
reviewed
Oct 26, 2021
This feature may help bypass this issue: appium/appium#14988 |
Updated description and title as well. |
zcmgyu
commented
Oct 28, 2021
KazuCocoa
reviewed
Oct 28, 2021
KazuCocoa
approved these changes
Oct 29, 2021
zcmgyu
commented
Oct 29, 2021
mykola-mokhnach
approved these changes
Oct 29, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Oct 29, 2021
# [3.56.0](v3.55.2...v3.56.0) (2021-10-29) ### Features * Control the visibility of the Tab Bar and Smart App Banner ([#1345](#1345)) ([d4e4e93](d4e4e93))
🎉 This PR is included in version 3.56.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I attempt to click a web element on iPad with
nativeWebTap
andnativeWebTapStrict
are enabled. Because of the existence of too many elements on the screen, it took me about 40 seconds to click that element. I figured out that finding the existence oftab bar
andsmart app banner
for measuring offset takes almost time. So I thought that being able to control this through the Settings API would help.After this PR, it takes me 10 seconds to click that element.
This feature may help bypass this issue: appium/appium#14988
Type of change
Usage
Test Configuration:
Checklist: