Use script to set security and run xcodebuild #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlipps
reviewed
Oct 6, 2016
| @@ -557,7 +557,10 @@ class XCUITestDriver extends BaseDriver { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| // there is no point in having `keychainPath` without `keychainPassword` | |||
| if ((caps.keychainPath && !caps.keychainPassword) || (!caps.keychainPath && caps.keychainPassword)) { | |||
There was a problem hiding this comment.
perhaps more compactly:
if (!(!!caps.keychainPath ^ !!caps.keychainPassword)) {but maybe too weird?
There was a problem hiding this comment.
oops sorry, got the polarity wrong, should just be:
if (!!caps.keychainPath ^ !!caps.keychainPassword) {since ^ returns 1 iff the boolean operands are different, which is the case we want here.
There was a problem hiding this comment.
I think you've pretty succinctly presented my case against using something like that. ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People have problems with running real device tests. There is a chance that this is caused by being unable to access the private key for the certificate. See appium/appium#6955