Add a possibility to set container type for Simulator #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgraham
reviewed
Sep 14, 2018
lib/commands/file-movement.js
Outdated
| } | ||
| const containerRoot = _.isFunction(containerRootSupplier) | ||
| ? await containerRootSupplier(bundleId, containerType) | ||
| : containerRootSupplier; | ||
| const resultPath = path.posix.resolve(containerRoot, match[2]); |
There was a problem hiding this comment.
Maybe we could have a variable for match[2] as well, like you did with bundleId?
dpgraham
reviewed
Sep 14, 2018
lib/commands/file-movement.js
Outdated
| let bundleId = match[1]; | ||
| let containerType = null; | ||
| const typeSeparatorPos = bundleId.indexOf(CONTAINER_TYPE_SEPARATOR); | ||
| if (typeSeparatorPos > 0 && typeSeparatorPos < bundleId.length - 1) { |
There was a problem hiding this comment.
Could you add a comment here that explains what this is doing and maybe even provide a small example
Something like:
// Parses bundleId and containerType from remote path string which has format `<bundleId>:<containerType>`
dpgraham
reviewed
Sep 14, 2018
lib/commands/file-movement.js
Outdated
| let bundleId = match[1]; | ||
| let containerType = null; | ||
| const typeSeparatorPos = bundleId.indexOf(CONTAINER_TYPE_SEPARATOR); | ||
| if (typeSeparatorPos > 0 && typeSeparatorPos < bundleId.length - 1) { |
There was a problem hiding this comment.
I'd like it if there were JSDocs for this method since I'm not too sure what this is supposed to do.
It should have been added already, but better late than never
added 2 commits
September 14, 2018 21:09
dpgraham
approved these changes
Sep 14, 2018
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
* Add a possibility to set container type for Simulator * Fix the returned value * make the calculation more precise * Address comments * Improve the error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on appium/node-simctl#57