Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mobile: command for siri client #837

Merged
merged 3 commits into from Nov 24, 2018

Conversation

Projects
None yet
3 participants
@mykola-mokhnach
Copy link
Contributor

commented Nov 23, 2018

Mykola Mokhnach

@mykola-mokhnach mykola-mokhnach requested review from jlipps and KazuCocoa Nov 23, 2018

Mykola Mokhnach
@KazuCocoa
Copy link
Member

left a comment

@@ -79,6 +79,8 @@ extensions.executeMobile = async function (mobileCommand, opts = {}) {
clearKeychains: 'mobileClearKeychains',

getPermission: 'mobileGetPermission',

activateSiri: 'mobileActivateSiri',

This comment has been minimized.

Copy link
@jlipps

jlipps Nov 24, 2018

Member

I would prefer one of these names:

  • siriCommand
  • siriVoiceCommand
  • siri
  • textToSiri

Or similar. I just want something that conveys we'll be passing a parameter to get siri to do something. Just saying "activate siri" to me sounds like we're enabling siri on the device, not actually using it.

This comment has been minimized.

Copy link
@mykola-mokhnach

mykola-mokhnach Nov 24, 2018

Author Contributor

changed to siriCommand

Mykola Mokhnach

@mykola-mokhnach mykola-mokhnach merged commit 59a8c4c into appium:master Nov 24, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
licence/cla Contributor License Agreement is signed.
Details
@jlipps

This comment has been minimized.

Copy link
Member

commented Nov 26, 2018

published in 2.104.0

@mykola-mokhnach mykola-mokhnach deleted the mykola-mokhnach:siri branch Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.