-
-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mobile: command for siri client #837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lib/commands/execute.js
Outdated
@@ -79,6 +79,8 @@ extensions.executeMobile = async function (mobileCommand, opts = {}) { | |||
clearKeychains: 'mobileClearKeychains', | |||
|
|||
getPermission: 'mobileGetPermission', | |||
|
|||
activateSiri: 'mobileActivateSiri', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer one of these names:
siriCommand
siriVoiceCommand
siri
textToSiri
Or similar. I just want something that conveys we'll be passing a parameter to get siri to do something. Just saying "activate siri" to me sounds like we're enabling siri on the device, not actually using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to siriCommand
published in 2.104.0 |
Based on appium/WebDriverAgent#129