Add mobile: command for siri client #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlipps
reviewed
Nov 24, 2018
lib/commands/execute.js
Outdated
| @@ -79,6 +79,8 @@ extensions.executeMobile = async function (mobileCommand, opts = {}) { | |||
| clearKeychains: 'mobileClearKeychains', | |||
|
|
|||
| getPermission: 'mobileGetPermission', | |||
|
|
|||
| activateSiri: 'mobileActivateSiri', | |||
There was a problem hiding this comment.
I would prefer one of these names:
siriCommandsiriVoiceCommandsiritextToSiri
Or similar. I just want something that conveys we'll be passing a parameter to get siri to do something. Just saying "activate siri" to me sounds like we're enabling siri on the device, not actually using it.
There was a problem hiding this comment.
changed to siriCommand
|
published in 2.104.0 |
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on appium/WebDriverAgent#129